Extension cleanup #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't look like Deface is being used anywhere in this gem, so we don't need to require it.
This is the standard we are adopting in Solidus extensions and it's more resilient and flexible than a simple constant.
aldesantis
force-pushed
the
aldesantis/extension-cleanup
branch
from
3dc1f63 to
4def45b
Compare
aldesantis
force-pushed
the
aldesantis/extension-cleanup
branch
2 times, most recently
from
3d0392f to
5803810
Compare
aldesantis
force-pushed
the
aldesantis/extension-cleanup
branch
from
5803810 to
a4cbe43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.