Spec suite maintenance #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Solidus v2.5 and upwards, using the aforementioned syntax caused an address state mismatch with the address country, causing the spec to fail
The previous cassettes did not contain the correct payload for the current EasyPost API version, which caused some specs to fail. The cassettes were re-recorded and the affected specs were updated to match the new payload.
This patch provides the following changes: * Remove unnecessary Rails dependency * Fix Git insecure data fetching warning
aitbw
force-pushed
the
aitbw/spec_suite_maintenance
branch
from
e185636 to
7813815
Compare
|
Thanks Angel!!!! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to get the Travis build green by doing the following:
defaceas dependency for Solidus versions lower than v2.5Spree::State.firstinstead ofFactoryBot.create(:state)Besides that, several deprecation warnings were fixed and various hacks were removed 🎉