Add new refresh config
#142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marbemac
reviewed
Jan 25, 2024
src/index.ts
Outdated
| @@ -255,7 +260,7 @@ export default function solidPlugin(options: Partial<Options> = {}): Plugin { | |||
| }, | |||
|
|
|||
| configResolved(config) { | |||
| needHmr = config.command === 'serve' && config.mode !== 'production' && options.hot !== false; | |||
| needHmr = config.command === 'serve' && config.mode !== 'production' && (options.hot !== false && !options.refresh.disabled); | |||
There was a problem hiding this comment.
!options.refresh.disabled -> !options.refresh?.disabled
The refresh object isn't guaranteed:
There was a problem hiding this comment.
Ditto the other spots further down that reach into the refresh object.
Might make sense to flip strict to true in the tsconfig to catch this kind of thing? Or at least strictNullChecks.
There was a problem hiding this comment.
Thanks! missed that minor detail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
refreshoption. Here are the following reasons:renderandcreateContext. SolidStart would highly benefit on this given that it wraps it withmount.hotoption. (not remove it)granularmode is now enabled by default, but there's no configurable way to disable it in Vite plugin.