Merge pull request #152 from atk/external-solid-for-testing-with-npm

import solid as external to fix testing with npm
solidjs · Mar 15, 2024 · 758f2af · 758f2af
2 parents 7500d78 + e52d554
commit 758f2af
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/fast-rocks-pump.md b/.changeset/fast-rocks-pump.md
@@ -0,0 +1,5 @@
+---
+"vite-plugin-solid": patch
+---
+
+import solid as external to fix testing with npm
diff --git a/src/index.ts b/src/index.ts
@@ -219,8 +219,8 @@ export default function solidPlugin(options: Partial<Options> = {}): Plugin {
 
         test.server = test.server || {};
         test.server.deps = test.server.deps || {};
-        if (!test.server.deps.inline?.find((item: string | RegExp) => /solid-js/.test(item.toString()))) {
-          test.server.deps.inline = [...(test.server.deps.inline || []), /solid-js/];
+        if (!test.server.deps.external?.find((item: string | RegExp) => /solid-js/.test(item.toString()))) {
+          test.server.deps.external = [...(test.server.deps.external || []), /solid-js/];
         }
 
         const jestDomImport = getJestDomExport(userSetupFiles);