Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all SPA templates (Vite 6) #153

Merged
merged 11 commits into from
Dec 1, 2024
Merged

Conversation

birkskyum
Copy link
Contributor

@birkskyum birkskyum commented Nov 26, 2024

Similar to

The official vite templates are updated already:

@amoutonbrady , @ryansolid , I believe this is sufficient to keep the spa templates well functional for another year or so.

This PR

All templates are:

  • Configured with "type": "module"
  • Using Vite 6
  • On all their latest dependencies, with pnpm v9
  • Running as expected (except ts-bootstrap, which before&after this has some sass warnings but is functional)
  • Remove solid-devtools, which has fallen a lot behind on deps (e.g. still on Vite 4), and already was commented out a year ago. To avoid install warnings, it's best to not have it bundled in it's current state. cc @thetarnav

Deprecated deps are removed (solid-testing-library, jest types that are bundled with the package etc). A lot of tickets closed because by moving to esm, or simply bumping (e.g. vitest)

@@ -1,4 +1 @@
#!/bin/sh
Copy link
Contributor Author

@birkskyum birkskyum Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These husky changes are just the migration steps outlined in the bottom of the release notes

https://github.com/typicode/husky/releases/tag/v9.0.1

@birkskyum birkskyum changed the title Update all SPA templates Update all SPA templates (Vite 6) Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment