Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses more on correcting bindings that are lost during the transformation process. Things like new functions, new variable declarations and new imports can cause issues with other babel plugins.
This involves:
@babel/helper-module-imports
.insertBefore
andreplaceWith
returns a new path. With that in mind, we can register the replacement declarations immediately after insertion. So no need to re-crawl the entire scope.Minor fix includes capturing the import declarations. The issue was that I initially added a check if the import is a normal import or a type import through
importKind === "value"
. Turns out that's not always true, so I did an inverse check instead.