Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prettier and autoformat hook #1

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Add prettier and autoformat hook #1

merged 1 commit into from
Apr 4, 2022

Conversation

nas5w
Copy link
Contributor

@nas5w nas5w commented Apr 4, 2022

  • Adds prettier default config + pre-commit hook that you can opt into
  • One time large code formatting to get that out of the way

@nas5w
Add prettier and autoformat hook
f507a74 
Test hook

Test hook and add readme

Test hook

Test hook
@nas5w nas5w requested review from Jutanium and nksaraf and removed request for Jutanium and nksaraf April 4, 2022 19:14
nksaraf
nksaraf reviewed Apr 4, 2022
View reviewed changes
Copy link
Member

@nksaraf nksaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good! There is some prettier rule that's adding commas at the end of lines even without another item in the list/object after it.. I think its "trailingCommas" or something like that. I am not sure if it its a good rule, but I don't really mind it

@nas5w
Copy link
Contributor Author

nas5w commented Apr 4, 2022

@nksaraf I don't care at all about which rules we use, just that we use consistent rules. So if you'd like to update the prettier config file with your preferred ruleset, have at it!

@nksaraf nksaraf merged commit 901a3ae into main Apr 4, 2022
@nksaraf nksaraf deleted the ns-add-prettier branch April 4, 2022 19:55
atilafassina added a commit that referenced this pull request Mar 3, 2024
@atilafassina @titoBouzout
Add i18n support to route architecture (#494)
6e329eb 
* add i18n support files

* replace default `<A>` with locale aware `<A>`

* add `tsx` support to route extensions

* i18n main navigation

* add ui translations

* improve links logic

* add locale to markdown links

* stale `<Show />` issue

* add space on readme

* remove `<Show>` callback

* add `keyed` to `<Show>`

* add missing UI translations

* remove extra character from list

* move entries selection outside of `createResource`

* get pagination back to references

* append `index` to locale root

* append locale to hero CTAs

* add i18n context

* remove `console.log`

* fix `addLocale`. Again.

* I18n links improvements (#1)

* ensure "edit this page" links to locale `index.mdx` when in a locale

* ensure "edit this page" links to locale `index.mdx` when in a locale

* add `isExternalURL` helper

* `target` is already handled on the link component

* use `isExternalURL` helper, target is handled by link component

* do not add locale to external links, locale link should be absolute

* ensure link doesnt end with a trailing slash when not localized

* address comments

* add 3rd case do i18n-anchor

* add missing UI translations

* add contributing docs

---------

Co-authored-by: Tito <[email protected]>
amirhhashemi added a commit to amirhhashemi/solid-docs-next that referenced this pull request Dec 22, 2024
@amirhhashemi
iteration solidjs#1
d51d873
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nksaraf nksaraf nksaraf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nas5w @nksaraf