Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rules to use typescript-eslint RuleCreator #88

Merged
merged 4 commits into from
Mar 23, 2023

Conversation

joshwilsonvu
Copy link
Collaborator

I came across https://typescript-eslint.io/custom-rules#rulecreator and found it to be nicer to work with than manually writing out the TSESLint.RuleModule<MessageIds, Options> type. The const createRule = ESLintUtils.RuleCreator.withoutDocs snippet isn't because there aren't docs; it's because those are already formatted with eslint-plugin-eslint-plugin, and it works better with a simple function call syntax.

The fixture test was taking a long time, so I put everything it checks for into one test so that it doesn't have to run ESLint multiple times.

Added other housekeeping, like support for TS satisfies, dependency version bumps, npm keywords, using a handy generator function for the fixer in no-destructure.

@joshwilsonvu joshwilsonvu self-assigned this Mar 19, 2023
@joshwilsonvu joshwilsonvu merged commit 584f2b5 into main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant