Silence reactivity warnings in (standard Web APIs) *Observer callbacks
#82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macarie
commented
Mar 4, 2023
Comment on lines
+889
to
+893
| "IntersectionObserver", | ||
| "MutationObserver", | ||
| "PerformanceObserver", | ||
| "ReportingObserver", | ||
| "ResizeObserver", |
There was a problem hiding this comment.
These should be all the standard Web APIs that have the same signature and behavior according to this MDN page.
|
Thanks for the contribution! You're absolutely right that these Observer callbacks should be handled by the rule in the same way as timers. I'll go ahead and get this merged shortly. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #81.
I don't have much experience building eslint rules, so I don't know if this is the right approach, but it seems to be working and doesn't break any existing tests.
If you don't think these warnings should be silenced, please, feel free to close the PR!