Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In components-return-once, don't treat callback functions as components. #37

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

joshwilsonvu
Copy link
Collaborator

Re: this message, some people are getting trouble with false positives from solid/components-return-once thinking createMemo functions are components.

This PR prevents the rule from considering callbacks from functions like createMemo as components. Specifically, that means functions starting with a lowercase letter; the minority of functions starting with an uppercase letter in Solid code are likely to be Higher-Order Components (HOCs) and callback functions there are still considered components.

@joshwilsonvu joshwilsonvu self-assigned this Nov 1, 2022
@joshwilsonvu joshwilsonvu merged commit 8c871ae into main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant