inline methods of jsx-ast-utils to simplify dependency tree #114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to simplify the dependency tree when using
eslint-plugin-solid
.eslint-plugin-solid
uses three methods fromjsx-ast-utils
:propName
,getProp
andhasProp
.The dependency tree of jsx-ast-utils is bloated as you can see in the changes in
pnpm-lock.yaml
, because it depends on all kinds of other packages to be backwards compatible with Node 4 and has no plan to change this (jsx-eslint/jsx-ast-utils#114).Removing
jsx-ast-utils
as dependency by inlining used methods would save users from installing up to 50 packages.All tests are green and I'm open for discussion/further work on this change.
Fixes #115