[skip ci] Update version script.

solidjs-community · Aug 31, 2024 · 1c96911 · 1c96911
1 parent 0f3be56
commit 1c96911
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/.github/workflows/version.yml b/.github/workflows/version.yml
@@ -41,7 +41,3 @@ jobs:
           delete-branch: true
           title: "Update package versions"
           body: "Merging this PR will publish packages to npm at the new version."
-      - name: Push tags
-        run: |
-          git switch gh-action-version
-          git push origin --tags
diff --git a/scripts/version.js b/scripts/version.js
@@ -34,8 +34,10 @@ await Promise.all([
   ),
 ]);
 await new Promise((resolve, reject) => {
+  // it's not ideal to create and push a tag at the time the PR is created, but once the PR is
+  // merged main should contain the tag as if it were created there.
   exec(
-    `git commit --all --message="v${newVersion}"; git tag "v${newVersion}";`,
+    `git commit --all --message="v${newVersion}"; git tag "v${newVersion}"; git push origin --force "v${newVersion}"`,
     (error, stdout, stderr) => {
       if (error) {
         reject(error);