Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate upcoming Community Solid Server release into the website #606

Merged
merged 2 commits into from
Aug 4, 2021

Conversation

RubenVerborgh
Copy link
Contributor

@RubenVerborgh RubenVerborgh commented Aug 3, 2021

This PR inserts documentation on how to install Community Solid Server v1.0.

@csarven
Copy link
Member

csarven commented Aug 3, 2021

Remind me.. is there a reference to where consensus was reached on this change/recommendation?

@jeff-zucker
Copy link
Member

May I ask about the intended transition process? I think it would really help implementers if there could be a period when CSS runs on an alternate port for testing before it replaces NSS on the main port. It would also be really helpful to have a rough timeline of when the testing server would be available and when the main port is targeted for switching to CSS. I also have questions about solidcommunity.net as an IDP - will the same registration processes be available?

@RubenVerborgh
Copy link
Contributor Author

Remind me.. is there a reference to where consensus was reached on this change/recommendation?

There is none; just trying to be helpful with getting the tutorial up to date.
Is there consensus needed for this beyond a review on this PR?

May I ask about the intended transition process?

Absolutely, we need one. And that's going to be a longer conversation.

This is just ensuring that new developers start out with the most spec-compatible Node.js implementation, to avoid creating new apps with old authentication methods, for instance.

I think it would really help implementers if there could be a period when CSS runs on an alternate port for testing before it replaces NSS on the main port.

I also have questions about solidcommunity.net as an IDP

I'm not sure if we're on the same page here; solidcommunity.net is not being replaced at this point in time.

This PR upgrades the docs for new developers to recommend CSS rather than NSS.

@jeff-zucker
Copy link
Member

Yes, I see now that prepping the onboarding materials is separate from transition of solidcommunity.net. Is there an issue about the transition on solidcommunity.net? If not, I'll create one.

I agree that it's a good idea to have the onboarding materials recommend CSS to new developers.What I would also like to see in the onboarding materials is a section aimed at existing developers who have aimed their apps at NSS. What should we expect in terms of differences? What things might we have wrongly gotten used to in NSS that won't work the same when spec compliant.

@RubenVerborgh
Copy link
Contributor Author

Is there an issue about the transition on solidcommunity.net?

I'm not sure if there is an issue; but I know that @justinwb is following up on that.

What I would also like to see in the onboarding materials is a section aimed at existing developers who have aimed their apps at NSS.

Okay if we track that in #607?

@csarven
Copy link
Member

csarven commented Aug 4, 2021

There is none; just trying to be helpful with getting the tutorial up to date.

Ack. Replacing NSS with CSS is a significant change. Ditto any implications on existing applications. (This is besides the point on moving things forward..)

Is there consensus needed for this beyond a review on this PR?

Perhaps the PR is sufficient but given its significance I think it'd be appropriate to raise this PR in the next Solid Team meeting, and make sure there are no objections, and concerns are acknowledged. It'd be good to mention the PR in solid/* chats etc.

@RubenVerborgh
Copy link
Contributor Author

Replacing NSS with CSS is a significant change.

It will be; but that's not the scope of this PR.

This PR adds new CSS documentation and removes old NSS documentation.
We deliberately do not make any suggestions about NSS being replaced, because that is not happening.

It'd be good to mention the PR in solid/* chats etc.

Indeed; tracking at:

raise this PR in the next Solid Team meeting

Unless this PR attracts significant feedback, will raise on 2021-08-11.

@Vinnl Vinnl requested a review from kay-kim August 4, 2021 14:38
@timbl
Copy link
Contributor

timbl commented Aug 4, 2021

"This is just ensuring that new developers start out with the most spec-compatible Node.js implementation, to avoid creating new apps with old authentication methods, for instance." -- well, NSS supports new auth methods as well as the old ones. The solid-ui stack needs to be upgraded. This is in process. Does the databrowser in general work with CSS? I suggest the solidproject.org mention both NSS and CSS for a while, don't just eliminate NSS.

@RubenVerborgh
Copy link
Contributor Author

RubenVerborgh commented Aug 4, 2021

Does the databrowser in general work with CSS?

It does not; because Databrowser is using old authentication protocols. And that's exactly what we want to avoid: new people starting out with old things.

I suggest the solidproject.org mention both NSS and CSS for a while, don't just eliminate NSS.

Point taken, I'll just change this PR to keep including NSS, and then there's nothing controversial.

@RubenVerborgh
Copy link
Contributor Author

Rewrote the PR to add CSS and keep the NSS documentation. Should be entirely uncontroversial now; asking @csarven to confirm if we can proceed with a simple review now. Note that the diff is not very helpful; when deployed, https://solidproject.org/self-hosting/nss/ remains identical to what it is today.

I would immensely appreciate if any of @justinwb @NSeydoux @csarven @jeff-zucker @kay-kim could review so we can launch this new page in time for Solid World tomorrow. Thanks in advance!

@ewingson
Copy link
Member

ewingson commented Aug 4, 2021

read attentively. as an contributor to https://solidproject.org/self-hosting/nss and maintainer of https://solidweb.org I think it's best to drive simultanously (NSS and CSS) for a while. perhaps onboarding for new people to CSS makes sense. as I can say for today, I will follow the switch of solidcommunity.net when it happens and do my best to admin the part I am responsible for as good as my knowledge is. thumbs up for discussion and building consensus.

@csarven
Copy link
Member

csarven commented Aug 4, 2021

To be clear, I only wanted to make sure there is sufficient consensus as well as community awareness on the change in these docs. Now that CSS information only adds to the existing docs, I think that's reasonable and hopefully welcomed by the others.

Copy link
Member

@csarven csarven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful to introduce CSS...

pages/faqs.md Outdated Show resolved Hide resolved
@RubenVerborgh
Copy link
Contributor Author

Thanks @ewingson @csarven @jeff-zucker @timbl, merging the addition.

@RubenVerborgh
Copy link
Contributor Author

RubenVerborgh commented Aug 4, 2021

Thanks @kay-kim, will take your suggestions into account before merging.

@RubenVerborgh RubenVerborgh deleted the feat/css branch August 4, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants