Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix avoid-late if initialized #71
Fix avoid-late if initialized #71
Changes from 17 commits
da4b854
f5f5bf2
e34f822
2633fc9
f5a4a81
78eef07
8aeeeb2
13b5e61
83629fe
13a6d16
56abdb6
6315eca
78246e9
dbd6bdf
d215871
f639d91
850cfaa
b426d49
b023b8c
b4fe907
662dc49
41fe9ab
8167c07
fbf2270
2037550
e3a85fa
bb69baa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove Flutter SDK dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can declare your own classes with same names for test purpose instead of pulling in the entire Flutter SDK as a dependency. See https://github.com/solid-software/solid_lints/pull/74/files#diff-f77bef8e8287cf15cac0245e3c6046109cd594bb0238e8bb61c991070521ab47
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I did it yesterday but create PR only today
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also test
allow_initialized == false
+ ignored types.