Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.1.0 preview #29

Merged
merged 81 commits into from
Nov 20, 2023
Merged
Changes from 1 commit
Commits
Show all changes
81 commits
Select commit Hold shift + click to select a range
4f9733f
Bump version to `0.1.0`
n-bernat Aug 9, 2023
557477a
Pull changes from `solid-metrics` repository
n-bernat Aug 9, 2023
4f0c2b2
Update .gitignore
n-bernat Aug 9, 2023
ec3115e
Update example/lib/solid_lints_example.dart
n-bernat Aug 9, 2023
86f590c
Update `CHANGELOG.md`
n-bernat Aug 9, 2023
e3c03e3
Add code checks with GitHub Actions
n-bernat Aug 10, 2023
948ff64
Add support for the number of parameters metric
n-bernat Aug 9, 2023
fbde0e3
Remove DCM references
n-bernat Aug 9, 2023
cac9a0e
Change lint message
n-bernat Aug 9, 2023
eee49ef
Simplify configuration and remove redundant code
n-bernat Aug 9, 2023
73077dd
Fix code comments
n-bernat Aug 9, 2023
afc2708
Add missing tests
n-bernat Aug 10, 2023
4f9adf4
Add `lines_of_code` lint
n-bernat Aug 10, 2023
f3fe762
Fix rule name
n-bernat Aug 10, 2023
0ab651f
Add test and fix an edge case
n-bernat Aug 10, 2023
56f76cb
Update lint to match the specification
n-bernat Aug 10, 2023
df96adb
Add `avoid_non_null_assertion` lint
n-bernat Aug 10, 2023
6347827
Add missing comment
n-bernat Aug 10, 2023
95e4feb
Add `avoid_late_keyword` lint
n-bernat Aug 10, 2023
b66319e
Update problem message
n-bernat Aug 10, 2023
9832ace
Add `avoid_global_state` lint
n-bernat Aug 10, 2023
eaf303d
Fix failing tests
n-bernat Aug 10, 2023
5ad8d92
Add `avoid_returning_widgets` lint
n-bernat Aug 11, 2023
f035b85
Use pattern-matching
n-bernat Aug 11, 2023
e80acbc
Simplify `isWidgetReturned`
n-bernat Aug 11, 2023
40453e7
Update lib/lints/avoid_returning_widgets/avoid_returning_widgets_rule…
n-bernat Aug 11, 2023
3943256
Cleanup of `getLintRules`
n-bernat Aug 11, 2023
3add16c
Fix comment
n-bernat Aug 11, 2023
fda7086
rename MetricRule -> RuleConfig
solid-yuriiprykhodko Aug 14, 2023
4aced0f
add a sceleton for the double-literal-format rule
xvadim Aug 30, 2023
930934c
implement the double-literal-format rule
xvadim Aug 30, 2023
95e7ed0
fix review warnings
xvadim Aug 30, 2023
877b985
implement quick-fix for the double-literal-format rule
xvadim Aug 30, 2023
b3fa08a
fix lint warnings
xvadim Aug 31, 2023
c1bd240
add avoid-unnecessary-type-assertions rule ('is' part)
xvadim Aug 31, 2023
e54e68c
fix lint warning
xvadim Aug 31, 2023
88d090e
add avoid-unnecessary-type-assertions rule ('whereType' part)
xvadim Aug 31, 2023
f212a30
add quick-fix for unnecessary operator is
xvadim Aug 31, 2023
48f9b0b
add quick-fix for unnecessary whereType
xvadim Sep 1, 2023
d89ff9d
fix review warnings; fix a bug
xvadim Sep 1, 2023
fcc7f8d
add utility class for type chekcking methods
xvadim Sep 1, 2023
a428495
add constants for is and whereType names
xvadim Sep 1, 2023
5c66691
add needed comments
xvadim Sep 1, 2023
ebe2120
rewrite _isUnnecessaryWhereType with pattern matching
xvadim Sep 1, 2023
a245487
rewrite _areGenericsWithSameTypeArgs with pattern matching
xvadim Sep 1, 2023
f8741ab
refactoring: move a castTypeInHierarchy to TypeCast class
xvadim Sep 1, 2023
d5ea780
implement "avoid unnecessary setstate" rule (#44)
laptevw Sep 4, 2023
bd420d8
Add avoid_unnecessary_type_casts_rule
Sep 13, 2023
eced630
Refactor types_utils, extract common methods
Sep 13, 2023
76cdcc9
Add fix for avoid_unnecessary_type_casts_rule
Sep 13, 2023
7e66eae
Add AvoidUnnecessaryTypeCastsRule.createRule to solid_lints.dart
Sep 13, 2023
0e20a72
Fix 'quickFix' for avoid-unnecessary-type-casts
Sep 13, 2023
2e1f56a
Add tests for avoid-unnecessary-type-casts
Sep 13, 2023
720f21f
Fix formatting
Sep 13, 2023
33a4bf5
Add more test cases
Sep 13, 2023
7cba149
Group code for more readability
Sep 13, 2023
f94fe97
Switch to getters, refactor areGenericsWithSameTypeArgs
Sep 13, 2023
af19c28
Avoid unrelated type assertions (#48)
DenisBogatirov Sep 13, 2023
063707e
Feature/newline before return (#52)
DenisBogatirov Sep 15, 2023
57b4f56
Fixes Issue #54 multiple rule reporting (#55)
DenisBogatirov Sep 15, 2023
59fe068
Feature/no empty block (#53)
DenisBogatirov Sep 15, 2023
581c725
Add no equal then else rule (#56)
DenisBogatirov Sep 15, 2023
39255dc
Feature/member ordering (#51)
DenisBogatirov Sep 15, 2023
c944ec1
Add avoid unused parameters rule (#49)
DenisBogatirov Sep 15, 2023
5690c93
Added no magic number rule (#57)
DenisBogatirov Sep 15, 2023
1f74e1b
Added prefer condtional expressions rule and fix (#59)
DenisBogatirov Sep 22, 2023
9666abd
Added prefer first rule (#60)
DenisBogatirov Sep 22, 2023
7030ab0
Add prefer last rule (#61)
DenisBogatirov Sep 22, 2023
b869a53
Add prefer match file name (#62)
DenisBogatirov Sep 22, 2023
b8e7659
Rename custom lints to use snake_case (#66)
solid-vovabeloded Nov 10, 2023
069ef6c
Take into account the constructor initializer in the avoid_unused_par…
solid-vovabeloded Nov 10, 2023
04ed7ac
Fix linter issues
vova-beloded-solid Nov 10, 2023
414c833
Bump custom_lint_builder version
vova-beloded-solid Nov 14, 2023
1ce6a91
Update LICENSE to include third party code license
illia-romanenko Nov 14, 2023
eb00fb4
Allow magic numbers for default values (#72)
solid-vovabeloded Nov 15, 2023
fbc158d
Ignore magic number in constructor initializer (#73)
solid-vovabeloded Nov 16, 2023
556d739
Remove DCM steps from readme
illia-romanenko Nov 16, 2023
6aae62c
Fix avoid-late if initialized (#71)
maxxlab Nov 17, 2023
414a14e
Implement proper-super-calls (#77)
maxxlab Nov 17, 2023
b45d2be
Ignore magic numbers in widget parameters (#74)
solid-vovabeloded Nov 20, 2023
7c3dd0e
Set default severity level to warning (#78)
solid-vovabeloded Nov 20, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add code checks with GitHub Actions
n-bernat authored and vova-beloded-solid committed Nov 10, 2023
commit e3c03e37d919734104cc1ba606afdddee1f4ad6e
44 changes: 44 additions & 0 deletions .github/workflows/flutter.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
name: Application ON Push & PR DO Code check
on: [push, pull_request]

jobs:
code-check:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3

- name: Setup Flutter
uses: subosito/flutter-action@v2
with:
channel: 'stable'

- name: Check Flutter SDK version
run: flutter --version

- name: Get dependencies
run: flutter pub get

- name: Check formatting
run: dart format . --set-exit-if-changed

# example app shows warnings as an example of a working linter, so
# we can't analyze it as its purpose is to have issues
- name: Disable analyzer for example app
run: rm example/analysis_options.yaml

- name: Run default analyzer
run: flutter analyze

- name: Run custom analyzer
run: dart run custom_lint

- name: Run tests
run: |
# run tests if `test` folder exists
if [ -d test ]
then
flutter test -r expanded
else
echo "Tests not found."
fi