add exclude params support to avoid_returning_widgets rule #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solid-vovabeloded
requested changes
Apr 19, 2024
There was a problem hiding this comment.
Well done, @4akloon! I've added a few suggestions here - please, take a look.
| reporter.reportErrorForNode(code, node); | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| bool _hasIgnored(Declaration node, DartType returnType) { |
There was a problem hiding this comment.
Suggested change
| bool _hasIgnored(Declaration node, DartType returnType) { | |
| bool _shouldIgnore(Declaration node, DartType returnType) { |
or
Suggested change
| bool _hasIgnored(Declaration node, DartType returnType) { | |
| bool _isIgnored(Declaration node, DartType returnType) { |
What do you think about this naming?
Comment on lines
113
to
127
| final excludedItem = config.parameters.exclude | ||
| .firstWhereOrNull((e) => e.methodName == methodName); | ||
|
|
||
| if (excludedItem | ||
| case AvoidReturningWidgetsExclude( | ||
| :final String? className, | ||
| )) { | ||
| if (className == null) { | ||
| return true; | ||
| } else { | ||
| return returnType.hasIgnoredType(ignoredTypes: {className}); | ||
| } | ||
| } | ||
|
|
||
| return false; |
There was a problem hiding this comment.
Suggested change
| final excludedItem = config.parameters.exclude | |
| .firstWhereOrNull((e) => e.methodName == methodName); | |
| if (excludedItem | |
| case AvoidReturningWidgetsExclude( | |
| :final String? className, | |
| )) { | |
| if (className == null) { | |
| return true; | |
| } else { | |
| return returnType.hasIgnoredType(ignoredTypes: {className}); | |
| } | |
| } | |
| return false; | |
| final excludedItem = config.parameters.exclude | |
| .firstWhereOrNull((e) => e.methodName == methodName); | |
| if (excludedItem == null) return false; | |
| final className = excludedItem.className; | |
| if (className == null) return false; | |
| return returnType.hasIgnoredType(ignoredTypes: {className}); |
I would refactor this part into something like this to make it a bit more readable. What do you think?
| - avoid_returning_widgets: | ||
| exclude: | ||
| - method_name: excludeWidget | ||
| class_name: SizedBox |
There was a problem hiding this comment.
The class_name means class in which we are ignoring returning widgets from the method_name, but not the return type of the ignored method_name.
Comment on lines
18
to
22
| for (final item in (json['exclude'] as Iterable?) ?? []) { | ||
| if (item is Map && item['method_name'] is String) { | ||
| exclude.add(AvoidReturningWidgetsExclude.fromJson(item)); | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| for (final item in (json['exclude'] as Iterable?) ?? []) { | |
| if (item is Map && item['method_name'] is String) { | |
| exclude.add(AvoidReturningWidgetsExclude.fromJson(item)); | |
| } | |
| } | |
| final excludeList = json['exclude'] as Iterable? ?? []; | |
| for (final item in excludeList) { | |
| if (item is Map) { | |
| exclude.add(AvoidReturningWidgetsExclude.fromJson(item)); | |
| } | |
| } |
I don't think we need to check the item structure here since it is not a responsibility of this class.
solid-vovabeloded
approved these changes
Apr 19, 2024
illia-romanenko
deleted the
131-allow-disabling-avoid_returning_widgets-for-certain-methods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.