Ignore magic number in constructor initializer (#73)

* Ignore magic number in constructor initializer * Minor naming improvement --------- Co-authored-by: vladimir-beloded <[email protected]>
solid-software · Nov 16, 2023 · fbc158d · fbc158d
1 parent eb00fb4
commit fbc158d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/lints/no_magic_number/no_magic_number_rule.dart b/lib/lints/no_magic_number/no_magic_number_rule.dart
@@ -70,7 +70,8 @@ class NoMagicNumberRule extends SolidLintRule<NoMagicNumberParameters> {
           .where(_isNotInDateTime)
           .where(_isNotInsideIndexExpression)
           .where(_isNotInsideEnumConstantArguments)
-          .where(_isNotDefaultValue);
+          .where(_isNotDefaultValue)
+          .where(_isNotInConstructorInitializer);
 
       for (final magicNumber in magicNumbers) {
         reporter.reportErrorForNode(code, magicNumber);
@@ -127,4 +128,8 @@ class NoMagicNumberRule extends SolidLintRule<NoMagicNumberParameters> {
   bool _isNotDefaultValue(Literal literal) {
     return literal.thisOrAncestorOfType<DefaultFormalParameter>() == null;
   }
+
+  bool _isNotInConstructorInitializer(Literal literal) {
+    return literal.thisOrAncestorOfType<ConstructorInitializer>() == null;
+  }
 }
diff --git a/lint_test/no_magic_number_test.dart b/lint_test/no_magic_number_test.dart
@@ -79,3 +79,10 @@ class DefaultValues {
 void topLevelFunctionWithDefaultParam({int value = 6}) {
   ({int value = 7}) {};
 }
+
+// Allowed for numbers in constructor initializer.
+class ConstructorInitializer {
+  final int value;
+
+  ConstructorInitializer() : value = 10;
+}