Fix no_magic_number missing reports

solid-software · Nov 15, 2023 · adfbfbd · adfbfbd
1 parent 1ce6a91
commit adfbfbd
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 5 deletions.
diff --git a/lib/lints/no_magic_number/no_magic_number_rule.dart b/lib/lints/no_magic_number/no_magic_number_rule.dart
@@ -83,11 +83,16 @@ class NoMagicNumberRule extends SolidLintRule<NoMagicNumberParameters> {
       (l is IntegerLiteral &&
           !config.parameters.allowedNumbers.contains(l.value));
 
-  bool _isNotInsideVariable(Literal l) =>
-      l.thisOrAncestorMatching(
-        (ancestor) => ancestor is VariableDeclaration,
-      ) ==
-      null;
+  bool _isNotInsideVariable(Literal l) {
+    AstNode? node = l;
+    while (node != null && node is! InstanceCreationExpression) {
+      if (node is VariableDeclaration) return false;
+
+      node = node.parent;
+    }
+
+    return true;
+  }
 
   bool _isNotInDateTime(Literal l) =>
       l.thisOrAncestorMatching(

diff --git a/lint_test/no_magic_number_test.dart b/lint_test/no_magic_number_test.dart
@@ -54,4 +54,18 @@ void fun() {
 
   // Allowed in DateTime because it doesn't have cons constructor
   final apocalypse = DateTime(2012, 12, 21);
+
+  const count = 5;
+  const total = 10;
+  // expect_lint: no_magic_number
+  final percent = TestMagicNumber(percent: (count / total) * 100);
+
+  // expect_lint: no_magic_number
+  TestMagicNumber(percent: (count / total) * 100);
+}
+
+class TestMagicNumber {
+  final double percent;
+
+  TestMagicNumber({required this.percent});
 }