Take into account the constructor initializer in the avoid_unused_par…

…ameters rule (#67) Co-authored-by: vladimir-beloded <[email protected]>
solid-software · Nov 10, 2023 · 069ef6c · 069ef6c
1 parent b8e7659
commit 069ef6c
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/lib/lints/avoid_unused_parameters/avoid_unused_parameters_visitor.dart b/lib/lints/avoid_unused_parameters/avoid_unused_parameters_visitor.dart
@@ -53,6 +53,7 @@ class AvoidUnusedParametersVisitor extends RecursiveAstVisitor<void> {
       _getUnusedParameters(
         node.body,
         parameters.parameters,
+        initializers: node.initializers,
       ).whereNot(nameConsistsOfUnderscoresOnly),
     );
   }
@@ -104,11 +105,13 @@ class AvoidUnusedParametersVisitor extends RecursiveAstVisitor<void> {
 
   Set<FormalParameter> _getUnusedParameters(
     AstNode body,
-    Iterable<FormalParameter> parameters,
-  ) {
+    Iterable<FormalParameter> parameters, {
+    NodeList<AstNode>? initializers,
+  }) {
     final result = <FormalParameter>{};
     final visitor = _IdentifiersVisitor();
     body.visitChildren(visitor);
+    initializers?.accept(visitor);
 
     final allIdentifierElements = visitor.elements;
 

diff --git a/lint_test/avoid_unused_parameters_test.dart b/lint_test/avoid_unused_parameters_test.dart
@@ -109,3 +109,13 @@ class TestWidget extends StatelessWidget {
     return const Placeholder();
   }
 }
+
+class UsingConstructorParameterInInitializer {
+  final int _value;
+
+  UsingConstructorParameterInInitializer(int value) : _value = value;
+
+  void printValue() {
+    print(_value);
+  }
+}