-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sd-combobox and sd-select [skip chromatic] #1742
base: next
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: fee8e6d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🚀 Storybook has been deployed for branch |
@DanielHargesheimer Could you have a look in the tests? Are they working on your side locally? I had some problems with them in another branch. |
@mariohamann |
@DanielHargesheimer We now fixed our tests on the pipeline due to a big architectural change. Could you please unskip all tests, that are working now? I skipped them in my branch to be able to merge: |
@smfonseca, @mariohamann |
I re-ran the failing job and it worked, but the combobox tests locally are still failing. |
I have tested locally and tests are passing |
It will be fixed on #1758 |
Description:
This pr closes: