Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set timeout in configuration file #20

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Set timeout in configuration file #20

merged 1 commit into from
Nov 4, 2020

Conversation

RubenVerborgh
Copy link
Contributor

@RubenVerborgh RubenVerborgh added the enhancement New feature or request label Nov 3, 2020
@michielbdejong
Copy link
Collaborator

Agreed that a --timeout command line option is nicer than the current env var, but I don't think this would make a difference to the default behaviour. I think the current behaviour on Travis is due to https://github.com/solid/community-server/pull/278/files#diff-75f636d6110cfd85820e36dd51f11ee57b99de6ccff526bf4e24f4ff53316715R11 which makes it use v0.1.1 instead of latest master.

I'll merge this, tag a new version, and use that in CommunitySolidServer/CommunitySolidServer#278

@michielbdejong michielbdejong merged commit a3ef4c2 into master Nov 4, 2020
@michielbdejong michielbdejong deleted the feature/global-settimeout branch November 4, 2020 08:14
@michielbdejong michielbdejong mentioned this pull request Nov 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michielbdejong michielbdejong Awaiting requested review from michielbdejong

Assignees

@michielbdejong michielbdejong

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RubenVerborgh @michielbdejong