Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add condition to stop field management factors being recognized as traits #5289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add condition to stop field management factors being recognized as traits #5289

wants to merge 1 commit into from

Conversation

bm743
Copy link
Contributor

@bm743 bm743 commented Jan 29, 2025

Description

Adds condition to fix field management factors being recognized as traits in BrAPI call
Solution by @chris263

Fixes #5273

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

@bm743 bm743 requested a review from chris263 January 29, 2025 22:12
@bm743 bm743 changed the title BrAPI BrAPI call crashing when field management factors present Jan 30, 2025
@bm743 bm743 changed the title BrAPI call crashing when field management factors present Add condition to stop field management factors being recognized as traits Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris263 chris263 Awaiting requested review from chris263

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BrAPI phenotype call crasing when field management factors are present
1 participant
@bm743