Sgn 5022 show stored analysis #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ata. Removed breeding program query. Changed queries for stored analysis function.
nmenda
requested changes
Nov 18, 2024
| AND cvterm.name!='phenotyping_experiment' | ||
| AND cvterm.name!='analysis_experiment' | ||
| AND breeding_program_id IS NULL;"; | ||
| } else { # Odds are if this is not an accession, it is a plot. |
There was a problem hiding this comment.
can it also be a plant or tissue sample? is the query going to work in such cases?
There was a problem hiding this comment.
I am pretty sure it would not work if those stocks were used but the original code that was there only distinguishes between accessions and non-accession stocks, and I did not want to change that. As far as I can tell though, these functions are only ever called on accessions and plots, so I do not think it matters. Would it be better to throw an error for invalid stock types?
There was a problem hiding this comment.
I think it would be better to be explicit about this, and check if the stock is an accession or a plot, and throw an error if neither
nmenda
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a function to Stock.pm to allow for the retrieval of stored analyses using a stock (accession only currently). The existing function for retrieving field trials from stock was changed to exclude breeding programs and stored analyses.