Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do comments panel update in background #205

Closed
solemnwarning opened this issue May 7, 2023 · 0 comments
Closed

Do comments panel update in background #205

solemnwarning opened this issue May 7, 2023 · 0 comments
Labels
performance
Milestone
0.61.0

Comments

@solemnwarning
Copy link
Owner

No description provided.

@solemnwarning solemnwarning added this to the 0.60.2 milestone Nov 4, 2023
solemnwarning added a commit that referenced this issue Nov 4, 2023
@solemnwarning
Do comments panel updates in batches (#205).
b044b30 
Populating the comments panel with a large number of comments can take
a while, most of which appears to be spent notifying the underlying
wxDataViewModel of changes, so we can't do it in a background thread.

We now do no more than 100 updates at a time, deferring further updates
into the idle event to keep the UI updating.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
0.61.0
Development

No branches or pull requests
1 participant
@solemnwarning