Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Go 1.10 to the Travis build matrix #41

Merged
merged 5 commits into from
Sep 11, 2018
Merged

Add Go 1.10 to the Travis build matrix #41

merged 5 commits into from
Sep 11, 2018

Conversation

cce
Copy link
Contributor

@cce cce commented Jul 16, 2018

No description provided.

@cce cce requested a review from jiwen624 July 16, 2018 20:41
Copy link
Contributor

@jiwen624 jiwen624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jiwen624
Copy link
Contributor

jiwen624 commented Jul 16, 2018

Seems we're hitting on this issue: travis-ci/travis-ci#9247

@jiwen624
Copy link
Contributor

One comment: if 1.10 is added, should we remove 1.7 as to supporting only the latest 3 releases?

@cheempz
Copy link
Contributor

cheempz commented Sep 10, 2018

Re:

One comment: if 1.10 is added, should we remove 1.7 as to supporting only the latest 3 releases?

Makes sense to me since golang's release policy would make 1.7 already not supported.

@codecov-io
Copy link

codecov-io commented Sep 10, 2018

Codecov Report

Merging #41 into master will decrease coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
- Coverage   83.19%   82.95%   -0.24%     
==========================================
  Files          32       32              
  Lines        2927     2927              
==========================================
- Hits         2435     2428       -7     
- Misses        429      435       +6     
- Partials       63       64       +1
Impacted Files Coverage Δ
v1/ao/internal/host/observer.go 81.59% <0%> (-5.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 489a314...9f85319. Read the comment docs.

@jiwen624 jiwen624 merged commit db6d697 into master Sep 11, 2018
@jiwen624 jiwen624 deleted the add_go_1.10 branch September 11, 2018 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants