Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RN Lib: Async-Await API #212

Merged
merged 10 commits into from
Mar 6, 2024
Merged

RN Lib: Async-Await API #212

merged 10 commits into from
Mar 6, 2024

Conversation

Funkatronics
Copy link
Contributor

No description provided.

Michaelsulistio
Michaelsulistio previously approved these changes Mar 2, 2024
View reviewed changes
@Funkatronics Funkatronics changed the title RN Lib: Async-Await API [WIP] RN Lib: Async-Await API Mar 2, 2024
@Funkatronics
Copy link
Contributor Author

Funkatronics commented Mar 2, 2024 •
edited
Loading

TODOs:

  • remove `...Async' naming from async methods
  • wrap native module into interface on js side
  • update example app to use new api (probably in a separate PR)
  • make timeout optional/configurable

@Funkatronics Funkatronics mentioned this pull request Mar 4, 2024
Merged
@Funkatronics Funkatronics changed the title [WIP] RN Lib: Async-Await API RN Lib: Async-Await API Mar 4, 2024
@Funkatronics Funkatronics merged commit e3feb4a into main Mar 6, 2024
@Funkatronics Funkatronics deleted the rn-async-await-api branch March 6, 2024 17:40
@Funkatronics Funkatronics mentioned this pull request Mar 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michaelsulistio Michaelsulistio Michaelsulistio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Funkatronics @Michaelsulistio