Update dependencies #673
Closed
Update dependencies #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordaaash
commented
Jan 12, 2024
| integrity sha512-tUd9srDLkRpe1BYg7we+c4UhRQkq+XQWswsr/L1xfGmoRDF47BPSXf4zE7ZU2GRBGvxtGt7lwJVAufQyQYhxTQ== | ||
| dependencies: | ||
| "@wallet-standard/base" "^1.0.1" | ||
| "@wallet-standard/features" "^1.0.3" |
There was a problem hiding this comment.
So this isn't ideal, we're ending up with two versions here...
There was a problem hiding this comment.
would adding a resolution here be appropriate? that resuts in
"@solana/wallet-standard-features@^1.1.0", "@solana/wallet-standard-features@^1.2.0":
version "1.2.0"
resolved "https://registry.yarnpkg.com/@solana/wallet-standard-features/-/wallet-standard-features-1.2.0.tgz#be8b3824abf5ebcfeaa7298445bf53f76a27c935"
integrity sha512-tUd9srDLkRpe1BYg7we+c4UhRQkq+XQWswsr/L1xfGmoRDF47BPSXf4zE7ZU2GRBGvxtGt7lwJVAufQyQYhxTQ==
dependencies:
"@wallet-standard/base" "^1.0.1"
"@wallet-standard/features" "^1.0.3"
in my testing. wallet-adapter build is still failing tho
|
apart from the duplicate wallet-standard-features dep, this LGTM. builds and runs fine for me locally. |
|
@jordaaash I am going to cherry pick these changes and merge them in, leaving out the react-native-walletlib changes for now since that is a separate lib and I want Mikes input before I go mucking around in there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to fix some dev/peer/dependencies and version discrepancies.