Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

ledger-tool: Disable os memory reporting on verify command by default #34469

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

steviez
Copy link
Contributor

@steviez steviez commented Dec 14, 2023

Problem

In most cases, the memory usage of solana-ledger-tool is not needed and adds extra noise to the log ouput.

Summary of Changes

Switch the default behavior from enabled to disabled for memory usage reporting. Note that the argument now differs from solana-validator; however, I think that is fine as again, lots of solana-ledger-tool runs are "one-offs" that we don't care about metrics for.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #34469 (37d4537) into master (fe7970c) will decrease coverage by 0.1%.
Report is 15 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #34469     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         819      819             
  Lines      220925   220925             
=========================================
- Hits       180918   180909      -9     
- Misses      40007    40016      +9     

@steviez steviez marked this pull request as ready for review December 14, 2023 23:16
@steviez steviez requested a review from t-nelson December 14, 2023 23:16
@steviez steviez merged commit eaec422 into solana-labs:master Dec 15, 2023
19 checks passed
@steviez steviez deleted the lt_no_mem_report branch December 15, 2023 15:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants