This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
solana-cli: format strings #34288
Merged
solana-cli: format strings #34288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
reviewed
Nov 30, 2023
brooksprumo
previously approved these changes
Nov 30, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34288 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 819 819
Lines 219969 220027 +58
=========================================
- Hits 180326 180318 -8
- Misses 39643 39709 +66 |
added 8 commits
November 30, 2023 19:27
CriesofCarrots
force-pushed
the
cli-fmt
branch
from
263a1cb to
f0954b9
Compare
|
Sorry @steviez , I squashed the nit fixes into their relevant file-commits before I realized that would make it hard to re-review 😞 |
steviez
reviewed
Dec 1, 2023
There was a problem hiding this comment.
I squashed the nit fixes into their relevant file-commits before I realized that would make it hard to re-review
No worries, luckily not every file was touched and I had bene using the feature of marking files as viewed. I think I found a few more that we might as well grab
CriesofCarrots
added
the
automerge
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is spun out from #34274
Problem
Long string literals can cause rustfmt to fail, which results in rustfmt failing to format entire functions. There are many instances of this in the solana-cli.
Summary of Changes
Format and wrap strings to allow rustfmt to work again.
This PR was initiated by adding
format_strings = trueto the workspace rustfmt.toml. In general, this did a nice job.However, I chose to manually preserve or improve some of the original strings where the formatting seemed to break readability. (It is just my own personal preference that
[default: ..]blocks not be broken across multiple lines.)If we impose
format_stringson the workspace in the future, these strings will be "wrong" and need fixing.