Refactor - Demotes Arc to Rc.
#32982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
previously approved these changes
Aug 24, 2023
Lichtso
force-pushed
the
refactor/demote_arc_to_rc
branch
from
02b36da
to
d23f429
Compare
|
Sorry @brooksprumo, forgot to run |
apfitzge
previously approved these changes
Aug 24, 2023
| @@ -98,8 +99,8 @@ pub struct RemoteWalletManager { | |||
| impl RemoteWalletManager { | |||
| /// Create a new instance. | |||
| #[cfg(feature = "hidapi")] | |||
| pub fn new(usb: Arc<Mutex<hidapi::HidApi>>) -> Arc<Self> { | |||
| Arc::new(Self { | |||
| pub fn new(usb: Arc<Mutex<hidapi::HidApi>>) -> Rc<Self> { | |||
There was a problem hiding this comment.
Potentially we should have been returning some sort of type aliased thing here?
That way we wouldn't have had so many changes from Arc -> Rc
Lichtso
force-pushed
the
refactor/demote_arc_to_rc
branch
from
5f92e45
to
8134f6a
Compare
Lichtso
force-pushed
the
refactor/demote_arc_to_rc
branch
from
8134f6a
to
b437b74
Compare
apfitzge
approved these changes
Aug 24, 2023
brooksprumo
approved these changes
Aug 24, 2023
Codecov Report
@@ Coverage Diff @@
## master #32982 +/- ##
=======================================
Coverage 81.9% 82.0%
=======================================
Files 784 784
Lines 212715 212715
=======================================
+ Hits 174426 174431 +5
+ Misses 38289 38284 -5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Another preparation for #32961.
Future versions of clippy will complain that:
Summary of Changes
Demotes
ArctoRcaroundRemoteWalletManager,LedgerWalletandTransactionAccounts.