This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Fix slot index used while calculating leader schedule #3017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- slot_leader_at() was using absolute slot number instead of index in the epoch
carllin
approved these changes
Feb 28, 2019
Codecov Report
@@ Coverage Diff @@
## master #3017 +/- ##
========================================
+ Coverage 76.8% 76.8% +<.1%
========================================
Files 130 130
Lines 19860 19861 +1
========================================
+ Hits 15261 15262 +1
Misses 4599 4599 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3017 +/- ##
========================================
+ Coverage 76.8% 76.8% +<.1%
========================================
Files 130 130
Lines 19860 19861 +1
========================================
+ Hits 15261 15262 +1
Misses 4599 4599 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
slot_leader_at() is using absolute slot number instead of index in the epoch
Summary of Changes
Calculate the index of slot in the current offset and use it to compute leader schedule