This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Fix flaky gossip weighted tests #2954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagar-solana
added
the
automerge
3 tasks
behzadnouri
pushed a commit
to behzadnouri/solana
that referenced
this pull request
Sep 24, 2024
…labs#2954) * Refactor remove_uncleaned_slots to reduce memory consumption * Avoid copying pubkeys
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Weighted Gossip tests were trying to work around rng from WeightedIndex.
Summary of Changes
The primary thing that needed testing here was that the largest stake holders are actually being listed as the heaviest weighted ones.