This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Persistent account store #2952
Closed
Persistent account store #2952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Accounts::has_accounts function for hash_internal_state calculation.
- Fix format check warnings
Also reduce some code duplication with cleanup_dirs fn.
rob-solana
reviewed
Feb 26, 2019
|
|
||
| bank | ||
| } | ||
|
|
||
| /// Create a new bank that points to an immutable checkpoint of another bank. | ||
| /// TODO: remove me in favor of _and_id(), id should not be an assumed value | ||
| pub fn new_from_parent(parent: &Arc<Bank>) -> Self { | ||
| static BANK_ID: AtomicUsize = AtomicUsize::new(1); |
There was a problem hiding this comment.
is this because ID figures in the path?
There was a problem hiding this comment.
Well it figures in the account set, so it has to be unique because the accounts store is shared between all banks in the system.
There was a problem hiding this comment.
It kind of hijacks this id, which was one of my concerns. Does it ruin it for what you wanted to do with it?
There was a problem hiding this comment.
I only added the += 1 stuff for tests. all other callers are calling new_from_parent_with_id()...
behzadnouri
pushed a commit
to behzadnouri/solana
that referenced
this pull request
Sep 27, 2024
yihau
pushed a commit
to yihau/solana
that referenced
this pull request
Sep 28, 2024
…a-labs#2952) (solana-labs#3005) Fix: Corrected the derivation command format (solana-labs#2952) (cherry picked from commit d2cc71f) Co-authored-by: Asten <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The cost of RAM is much higher that adds up to the cost of operating a full node (16GB of RAM is the same cost as 500GB of high speed NVMe SSDs). Look into ways to reduce the RAM usage by moving some of the data onto SSDs and have them loaded / stored on demand.
Summary of Changes
Implements #2769
To help reduce RAM usage of the nodes, persist storage of accounts across NVMe SSDs and load / store them on a need basis from SSDs.
Store account information across two files: Index and Data
Index: Contains offset into data
Data: Contains the length followed by the account data
The accounts are split across NVMe SSDs using the pubkey as the key.
Fixes: #2499