Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Squash the new working bank to ensure zero-balance accounts get purged #2950

Merged
merged 1 commit into from
Feb 26, 2019

Conversation

mvines
Copy link
Contributor

@mvines mvines commented Feb 26, 2019

test_zero_balance_after_nonzero is green at the tip only because it completes before the first rotation occurs.

  1. Force a rotation during test_zero_balance_after_nonzero to show it fails
  2. Add a squash() into replay stage to avoid hitting
    // store default account if balance is 0 and there's a checkpoint
    self.accounts.insert(pubkey.clone(), Account::default());

@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #2950 into master will increase coverage by 2.1%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #2950     +/-   ##
========================================
+ Coverage    76.2%   78.3%   +2.1%     
========================================
  Files         127     127             
  Lines       20191   19641    -550     
========================================
  Hits        15391   15391             
+ Misses       4800    4250    -550

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant