This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
blocktree_processor to use slots as bank ids and squash() #2949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
rob-solana
commented
Feb 26, 2019
| bank_id: slot, | ||
| entry_height, | ||
| last_entry_id, | ||
| next_blob_index: meta.consumed, |
There was a problem hiding this comment.
@carllin this is what I'd like to see, but it's failing the 2 node 1 tick/slot test...
rob-solana
force-pushed
the
blocktree_processor.bank_id
branch
from
4bde968 to
1e52e9b
Compare
Codecov Report
@@ Coverage Diff @@
## master #2949 +/- ##
========================================
- Coverage 78.3% 71.8% -6.6%
========================================
Files 127 127
Lines 19719 21525 +1806
========================================
+ Hits 15456 15471 +15
- Misses 4263 6054 +1791 |
garious
approved these changes
Feb 26, 2019
garious
reviewed
Feb 26, 2019
|
I think you're also going to have to change how these two lines interoperate:
If we give replay stage a completed slot n, line 1 is going to get the blob index for the end of slot n, but line 2 is going to set current_slot to slot n + 1 |
rob-solana
force-pushed
the
blocktree_processor.bank_id
branch
from
1e52e9b to
6b26f58
Compare
rob-solana
force-pushed
the
blocktree_processor.bank_id
branch
from
6b26f58 to
3f8edb8
Compare
|
ship it |
|
Yes please, I want to rebase on this |
3 tasks
brooksprumo
pushed a commit
to brooksprumo/solana
that referenced
this pull request
Sep 19, 2024
* build(deps): bump bytes from 1.7.1 to 1.7.2 Bumps [bytes](https://github.com/tokio-rs/bytes) from 1.7.1 to 1.7.2. - [Release notes](https://github.com/tokio-rs/bytes/releases) - [Changelog](https://github.com/tokio-rs/bytes/blob/master/CHANGELOG.md) - [Commits](tokio-rs/bytes@v1.7.1...v1.7.2) --- updated-dependencies: - dependency-name: bytes dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Update all Cargo files --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
the 2 above combine to construct a bankforks that doesn't match the behavior of replay_stage or of (soon) locktower
Summary of Changes
Fixes #