Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Plumb BankForks into GossipService #2866

Merged
merged 1 commit into from
Feb 21, 2019
Merged

Conversation

mvines
Copy link
Contributor

@mvines mvines commented Feb 21, 2019

Depends-on: #2865

@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #2866 into master will increase coverage by <.1%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #2866     +/-   ##
========================================
+ Coverage    78.1%   78.1%   +<.1%     
========================================
  Files         127     127             
  Lines       19374   19381      +7     
========================================
+ Hits        15147   15153      +6     
- Misses       4227    4228      +1

@mvines mvines requested a review from sagar-solana February 21, 2019 05:48
Copy link
Contributor

@sagar-solana sagar-solana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine by me. However, maaaybe grabbing this lock every 100ms isn't the best thing. If you agree, I'll fix it later.

@mvines
Copy link
Contributor Author

mvines commented Feb 21, 2019

Yeah seems like a potential optimization (that I'd totally not bother with until it shows up in a profile)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants