This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Cleanup stakes for gossip #2860
Merged
sagar-solana
merged 4 commits into
solana-labs:master
from
sagar-solana:cleanup_gossip_stakes
Feb 21, 2019
Merged
Cleanup stakes for gossip #2860
sagar-solana
merged 4 commits into
solana-labs:master
from
sagar-solana:cleanup_gossip_stakes
Feb 21, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garious
reviewed
Feb 21, 2019
runtime/Cargo.toml
Outdated
@@ -15,6 +15,7 @@ fnv = "1.0.6" | |||
hashbrown = "0.1.8" | |||
log = "0.4.2" | |||
rand = "0.6.5" | |||
rayon = "1.0.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you using this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh dang, I was earlier. I'll get rid of it asap. Thanks!
garious
approved these changes
Feb 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So pretty. Thanks!
Codecov Report
@@ Coverage Diff @@
## master #2860 +/- ##
========================================
- Coverage 78.1% 78.1% -0.1%
========================================
Files 127 127
Lines 19336 19280 -56
========================================
- Hits 15106 15058 -48
+ Misses 4230 4222 -8 |
ryoqun
pushed a commit
to ryoqun/solana
that referenced
this pull request
Sep 9, 2024
* fix some args name in the wen restart log * remove hard fork
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Gossip isn't correctly using stakes, instead its just using a node's bank balance.
Summary of Changes
Added a method to bank to populate
stakes
and updated gossip to use a Map of node ids and stakes instead of plumbingbank
into the deepest depths of gossip.Fixes #