-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump prost, tonic to pick up protoc fix #26854
Conversation
9869b4b
to
43a5689
Compare
8bf5583
to
5737be0
Compare
5737be0
to
aa333e9
Compare
aa333e9
to
8fd5e8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
if std::env::var(PROTOC_ENVAR).is_err() { | ||
std::env::set_var(PROTOC_ENVAR, protobuf_src::protoc()); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could just unwrap_or()
, but this works too
It seems like prost building from source causes issue with the Homebrew package manager: Homebrew/homebrew-core#106928 (comment) |
Is it possible that this change is causing issues here? https://github.com/solana-labs/solana/runs/7696195623?check_suite_focus=true
|
@jstarry Yes, since protobuf-src needs a C compiler. Good luck with that on Windows 😂
|
Problem
Protobufs build fails often in CI. Appears to be this issue: tokio-rs/prost#653
Summary of Changes
Bump prost (and related deps) to pick up fix.
3rd commit is still a question mark for me. This commit moves to compiling protoc from source, which definitely adds some time to fresh builds, but might make building less brittle. As of #25424, we recommend installing the protobuf compiler, but I'm not sure very many people have, since it doesn't seem to actually be necessary.