fix: add bigint support to system transfers #24975
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR was made by @konytech, but @steveluscher is an idiot and accidentally corrupted #24797; reopened it as this PR.
Problem
System transfers only support the 'number' type for lamports. For transferring large amounts, supporting 'bigint' like it's done in the spl-token library is required.
This follows the same encoding/decoding approach used by the spl-token library:
https://github.com/solana-labs/solana-program-library/blob/master/token/js/src/instructions/transfer.ts#L56
Summary of Changes