Eliminate circular dependencies in web3 js #24729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #24729 +/- ##
=======================================
Coverage 70.0% 70.0%
=======================================
Files 37 38 +1
Lines 2301 2303 +2
Branches 325 325
=======================================
+ Hits 1612 1614 +2
Misses 573 573
Partials 116 116 |
jstarry
previously approved these changes
Apr 27, 2022
web3.js/src/transaction-constants.ts
Outdated
| */ | ||
| export const PACKET_DATA_SIZE = 1280 - 40 - 8; | ||
|
|
||
| export const SIGNATURE_LENGTH = 64; |
There was a problem hiding this comment.
Can you add docs that state this length is measured in bytes (as opposed to base58 string length)
This was referenced May 28, 2022
This was referenced May 31, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
* chore: enable circular dependency warnings on build * fix: eliminate circular dependencies in web3.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Circular dependencies are actually really really bad. Let's eliminate them and keep them out.
Musing: I haven't checked yet, but I wonder if this might have something to do with why some folks are having so much trouble doing tree-shaking.
Summary of Changes