Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: compile web3.js tests with the same compiler as the build itself #24728

Merged
merged 1 commit into from
Apr 27, 2022
Merged

chore: compile web3.js tests with the same compiler as the build itself #24728

merged 1 commit into from
Apr 27, 2022

Conversation

steveluscher
Copy link
Contributor

Problem

You can use modern TypeScript language features in the code (like ?? and ?.) but if you try to run the tests they'll explode.

UNTIL NOW.

Summary of Changes

Use the same compiler for the tests as we do for the production build.

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #24728 (f3e5640) into master (8ba003a) will decrease coverage by 11.7%.
The diff coverage is n/a.

❗ Current head f3e5640 differs from pull request most recent head ecfe74d. Consider uploading reports for the commit ecfe74d to get more accurate results

@@             Coverage Diff             @@
##           master   #24728       +/-   ##
===========================================
- Coverage    81.8%    70.0%    -11.8%     
===========================================
  Files         632       37      -595     
  Lines      167499     2301   -165198     
  Branches      322      325        +3     
===========================================
- Hits       137169     1613   -135556     
+ Misses      30217      573    -29644     
- Partials      113      115        +2     

Copy link
Member

@jstarry jstarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you thank you thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants