Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Rerun if any file in a directory has changed #2343

Merged
merged 1 commit into from
Jan 9, 2019

Conversation

jackcmay
Copy link
Contributor

@jackcmay jackcmay commented Jan 9, 2019

Problem

Rust build scripts are rerun if specified files are modified but requires each file to be specified individually. This is prone to error since a file might be added without the build script being updated.

Summary of Changes

This change adds the ability to specify directories, if any file in the specified directory changes the build will be re-run.

Fixes #

@codecov
Copy link

codecov bot commented Jan 9, 2019

Codecov Report

Merging #2343 into master will decrease coverage by 3.1%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #2343     +/-   ##
========================================
- Coverage    74.2%   71.1%   -3.2%     
========================================
  Files         112     112             
  Lines       17616   18381    +765     
========================================
- Hits        13081   13078      -3     
- Misses       4535    5303    +768

@jackcmay jackcmay requested a review from mvines January 9, 2019 06:53
@jackcmay jackcmay added this to the v0.12 Beacons milestone Jan 9, 2019
@jackcmay jackcmay merged commit 56b6ed6 into solana-labs:master Jan 9, 2019
@jackcmay jackcmay deleted the rerun_directories branch January 9, 2019 17:56
ripatel-fd pushed a commit to ripatel-fd/solana that referenced this pull request Aug 8, 2024
…olana-labs#2314) (solana-labs#2343)

ledger-tool: Set initial last full snapshot slot (solana-labs#2314)

(cherry picked from commit 75a640e)

Co-authored-by: Brooks <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant