Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

[Explorer] Change to consume @metaplex/js #20637

Merged
merged 5 commits into from
Oct 17, 2021
Merged

[Explorer] Change to consume @metaplex/js #20637

merged 5 commits into from
Oct 17, 2021

Conversation

roederw
Copy link
Contributor

@roederw roederw commented Oct 12, 2021 •
edited
Loading

Metaplex published @metaplex/js based on this repo.

  • Started consuming @metaplex/js
  • Removed all the duplicated logic/schemas that was required to make Metaplex NFTs work in the Explorer.
  • Moved metaplex/Art.tsx and metaplex/useArt.ts to components/common/NFTArt.tsx
  • Unfortunately this change stops supporting HTML categories. Have a PR open to add it back.

@mergify mergify bot added the community Community contribution label Oct 12, 2021
@mergify mergify bot requested a review from a team October 12, 2021 20:40
@roederw
Copy link
Contributor Author

roederw commented Oct 12, 2021

This is going to have a bunch of conflicts since @oJshua pushed in my other PR. Let me resolve them quickly.

@roederw
Copy link
Contributor Author

roederw commented Oct 14, 2021

This is going to have a bunch of conflicts since @oJshua pushed in my other PR. Let me resolve them quickly.

@oJshua Good to go.

@oJshua oJshua self-requested a review October 17, 2021 02:06
oJshua
oJshua approved these changes Oct 17, 2021
View reviewed changes
Copy link
Contributor

@oJshua oJshua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@oJshua oJshua added the automerge Merge this Pull Request automatically once CI passes label Oct 17, 2021
@mergify mergify bot merged commit 05569ca into solana-labs:master Oct 17, 2021
dankelleher pushed a commit to identity-com/solana that referenced this pull request Nov 24, 2021
@roederw @dankelleher
[Explorer] Change to consume @metaplex/js (solana-labs#20637)
23b6ee5 
* Removed duplicated Metaplex logic/schemas and instead consume @metaplex/js

* Bumped @metaplex/js version to 1.2.0

Co-authored-by: Will Roeder <[email protected]>
frits-metalogix added a commit to identity-com/solana that referenced this pull request Nov 24, 2021
@frits-metalogix
Revert "[Explorer] Change to consume @metaplex/js (solana-labs#20637)"
a00303c 
This reverts commit 23b6ee5.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@oJshua oJshua oJshua approved these changes

Assignees
No one assigned
Labels
automerge Merge this Pull Request automatically once CI passes community Community contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roederw @oJshua