This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Add default() to SnapshotConfig #19776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19776 +/- ##
=========================================
- Coverage 82.5% 82.5% -0.1%
=========================================
Files 472 472
Lines 132587 132583 -4
=========================================
- Hits 109511 109491 -20
- Misses 23076 23092 +16 |
| snapshot_utils::DEFAULT_FULL_SNAPSHOT_ARCHIVE_INTERVAL_SLOTS, | ||
| incremental_snapshot_archive_interval_slots: | ||
| snapshot_utils::DEFAULT_INCREMENTAL_SNAPSHOT_ARCHIVE_INTERVAL_SLOTS, | ||
| snapshot_archives_dir: PathBuf::default(), |
There was a problem hiding this comment.
is this == snapshot_archives_dir: PathBuf::from("/"),?
There was a problem hiding this comment.
Good catch! No, it's basically an empty string, like String::new(), which ends up being basically Vec::new().
In the rpc_service test that sets snapshot_archive_dir and bank_snapshots_dir to PathBuf::from("/"), the values don't matter at all, just that SnapshotConfig is Some and not None.
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
This reverts commit 47bf811.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SnapshotConfig is about to get more parameters, and updating all its uses can be cumbersome. Adding default() simplifies future PRs.
Summary of Changes
Add default() to SnapshotConfig and then update all its uses.