Enable more fine-grained control in local cluster partition tests #10418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10418 +/- ##
=======================================
Coverage 81.6% 81.6%
=======================================
Files 295 295
Lines 69154 69166 +12
=======================================
+ Hits 56448 56463 +15
+ Misses 12706 12703 -3 |
mergify bot
pushed a commit
that referenced
this pull request
Jun 5, 2020
Co-authored-by: Carl <[email protected]> (cherry picked from commit db82d9e)
solana-grimes
pushed a commit
that referenced
this pull request
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
run_cluster_partitionis very monolithic and hard to adapt to new test cases/different integrity checks. Extracted from: #10343Summary of Changes
Give local cluster
run_cluster_partitionmethod on_partition_startandon_partition_end` event callbacks to give more flexibility in when to kill nodes/different types off integrity checks, etc.Fixes #