This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Add missing space attribute to accounts #3575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c1bb77a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
BundleMonUnchanged files (125)
Total files change +29B +0.01% Final result: ✅ View report in BundleMon website ➡️ |
lorisleiva
force-pushed
the
loris/add-space-to-account-info
branch
from
59284c9 to
c1bb77a
Compare
mcintyre94
approved these changes
Nov 15, 2024
This was referenced Nov 19, 2024
Closed
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing
spaceattribute to:AccountInfoBasetype from@solana/rpc-types.BaseAccounttype from@solana/accounts.Tests
In terms of tests, I just needed to update some existing one that were using mock data but all the ones using a local validator (including
jsonParsedfetches) are already asserting that we get aspaceattribute. We were just not capturing it in the types.Release
I believe this is a
patchchange because, even though this is adding a type attribute, the data was already there so we are just fixing our type representation to match the data correctly. Lmk if you agree with this as we're figuring out our stance of versioning/releasing.Addresses solana-labs/web3.js-issue-conveyer#3