__DEV__ logic is now ‘NODE_ENV is not production’

[steveluscher]

Summary

A few folks have been caught out not having any setting for NODE_ENV. In cases like this, the __DEV__ flag will be false because NODE_ENV is not 'development'.

It would be preferable for development to be the default when there is no NODE_ENV. This means it will be harder to get ‘into’ production mode (you have to set an env variable) but it will mean that people fall into the pit of success when debug functionality is what they're looking for.

Test Plan

pnpm i
pnpm turbo compile:js

Observe that all of the __DEV__ constants have been replaced with process.env.NODE_ENV !== 'production'

[changeset-bot]

🦋 Changeset detected

Latest commit: b9f7231

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages

Name	Type
@solana/errors	Patch
@solana/rpc	Patch
@solana/rpc-subscriptions	Patch
@solana/rpc-subscriptions-transport-websocket	Patch
@solana/rpc-transport-http	Patch
@solana/webcrypto-ed25519-polyfill	Patch
@solana/accounts	Patch
@solana/addresses	Patch
@solana/assertions	Patch
@solana/codecs-core	Patch
@solana/codecs-data-structures	Patch
@solana/codecs-numbers	Patch
@solana/codecs-strings	Patch
@solana/compat	Patch
@solana/instructions	Patch
@solana/keys	Patch
@solana/web3.js-experimental	Patch
@solana/options	Patch
@solana/programs	Patch
@solana/react	Patch
@solana/rpc-api	Patch
@solana/rpc-spec	Patch
@solana/rpc-subscriptions-spec	Patch
@solana/rpc-types	Patch
@solana/signers	Patch
@solana/sysvars	Patch
@solana/transaction-confirmation	Patch
@solana/transaction-messages	Patch
@solana/transactions	Patch
@solana/rpc-graphql	Patch
@solana/rpc-subscriptions-api	Patch
@solana/rpc-parsed-types	Patch
@solana/codecs	Patch
@solana/rpc-transformers	Patch
@solana/fast-stable-stringify	Patch
@solana/functional	Patch
@solana/rpc-spec-types	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[steveluscher]

• __DEV__ logic is now ‘NODE_ENV is not production’ #2907 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @steveluscher and the rest of your teammates on Graphite

[steveluscher]

cc/ @Jac0xb

[steveluscher]

This mirrors, for instance, React's behaviour. Their library uses process.env.NODE_ENV === 'production' to kick it into production mode.

[mcintyre94]

LGTM!

[mcintyre94]

CI error seems to be related to the changes in this file - are they intended to be in this PR at all?

[steveluscher]

Hmm. This change was supposed to fix a test failure owing to the fact that error 123 doesn’t exist.

[steveluscher]

Oh, it’s lint I left behind.

Maybe I’ll try to do this properly with mocks this time.

[lorisleiva]

Thanks, I'll make sure I replicate on Kinobi when I'm out of this documentation hole.

[github-actions]

🎉 This PR is included in version 1.95.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[github-actions]

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.