Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate deprecated RPC methods #2859

Closed
steveluscher opened this issue Jun 26, 2024 · 8 comments · Fixed by KaliforniaShell/solana-program-library#1 · 4 remaining pull requests
Closed

Eliminate deprecated RPC methods #2859

steveluscher opened this issue Jun 26, 2024 · 8 comments · Fixed by KaliforniaShell/solana-program-library#1 · 4 remaining pull requests
Labels
enhancement New feature or request

Comments

@steveluscher
Copy link
Collaborator

steveluscher commented Jun 26, 2024

The following deprecated methods are being removed in Agave 2.0:

  • confirmTransaction
  • getSignatureStatus
  • getSignatureConfirmation
  • getTotalSupply
  • getConfirmedSignaturesForAddress
  • getConfirmedBlock
  • getConfirmedBlocks
  • getConfirmedBlocksWithLimit
  • getConfirmedTransaction
  • getConfirmedSignaturesForAddress2
  • getRecentBlockhash
  • getFees
  • getFeeCalculatorForBlockhash
  • getFeeRateGovernor
  • getSnapshotSlot
  • getStakeActivation

Clean all references and code for these from web3.js.

@steveluscher
Copy link
Collaborator Author

I've started to have a few second thoughts here.

  1. Responsibly removing these methods would require a major version bump, which would take legacy web3.js to 2.0.
  2. The new library that we actually intend on releasing as web3.js 2.0 already has these methods gone.

I think maybe we just cut our losses for legacy, and close #2859 by releasing the new library. Two birds, one stone.

@logandelafosse
Copy link

I've started to have a few second thoughts here.

  1. Responsibly removing these methods would require a major version bump, which would take legacy web3.js to 2.0.
  2. The new library that we actually intend on releasing as web3.js 2.0 already has these methods gone.

I think maybe we just cut our losses for legacy, and close #2859 by releasing the new library. Two birds, one stone.

Hi Steve,

Is there an estimate on when the new library will be released? Or, if it is already released, can you help me with a link?

@steveluscher
Copy link
Collaborator Author

Hey @sekaieth; you can follow along with the Release Candidates here. It's looking like the final will come shortly after Solana Breakpoint this year.

@logandelafosse
Copy link

Thanks!

I'm on a wallet team. Will the Agave 2.0 fork break my application if we don't upgrade this sdk immediately?

@steveluscher
Copy link
Collaborator Author

The versions aren't related. @solana/web3.js 2.0 breaks all APIs from the application perspective, not the network perspective. There are no RPC API changes between the network at 1.18 or 2.0, except that some long-deprecated methods have been permanently removed.

@logandelafosse
Copy link

Thanks!

steveluscher added a commit that referenced this issue Oct 22, 2024
# Summary

This was removed in anza-xyz/agave#2044. 2.0 is close enough to mainnet that we might as well do this now.

Closes #1564.
Addresses #2859.
@steveluscher
Copy link
Collaborator Author

This is done in 2.0. We're not going to remove them in the 1.x line.

Copy link
Contributor

Because there has been no activity on this issue for 7 days since it was closed, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.