Refactor - Stops clobbering FRAME_PTR_REG in ANCHOR_INTERNAL_FUNCTION_CALL_REG
#637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasSte
reviewed
Nov 26, 2024
| self.emit_ins(X86Instruction::mov(OperandSize::S64, reg, REGISTER_MAP[FRAME_PTR_REG])); | ||
| // REGISTER_SCRATCH contains self.pc, and we must store it for proper error handling. | ||
| // We can discard the value if callx succeeds, so we are not incrementing the stack pointer (RSP). | ||
| self.emit_ins(X86Instruction::store(OperandSize::S64, REGISTER_SCRATCH, RSP, X86IndirectAccess::OffsetIndexShift(-24, RSP, 0))); |
There was a problem hiding this comment.
Would it be possible to use another x86 register here? I'm concerned that adding loads and stores may impact performance.
There was a problem hiding this comment.
It is the same store that was inside the anchored subroutine before, just inlined here. The only thing this makes worse is more bytes emitted per callx.
Lichtso
force-pushed
the
refactor/FRAME_PTR_REG_in_ANCHOR_INTERNAL_FUNCTION_CALL_REG
branch
from
52168af
to
ea2b29a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #637 +/- ##
==========================================
- Coverage 90.09% 89.99% -0.11%
==========================================
Files 22 22
Lines 9726 10314 +588
==========================================
+ Hits 8763 9282 +519
- Misses 963 1032 +69 ☔ View full report in Codecov by Sentry. |
LucasSte
approved these changes
Nov 27, 2024
Lichtso
deleted the
refactor/FRAME_PTR_REG_in_ANCHOR_INTERNAL_FUNCTION_CALL_REG
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.