Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom deposit amounts #121

Conversation

Flaque
Copy link
Contributor

@Flaque Flaque commented Dec 8, 2021

Revives #38 since it seems like Max's comment (blockworks-foundation#38 (comment)) here has been resolved by @SebastianBor's commit.

Opening this as a draft while I test it a bit.

Co-authored-by: saml33 [email protected]
Co-authored-by: flaque [email protected]

Co-authored-by: saml33 <[email protected]>
Co-authored-by: flaque <[email protected]>
@netlify
Copy link

netlify bot commented Dec 8, 2021

✔️ Deploy Preview for sad-einstein-a108a8 ready!

🔨 Explore the source changes: 49b7828

🔍 Inspect the deploy log: https://app.netlify.com/sites/sad-einstein-a108a8/deploys/61b2295782ec68000828b1d3

😎 Browse the preview: https://deploy-preview-121--sad-einstein-a108a8.netlify.app

@netlify
Copy link

netlify bot commented Dec 8, 2021

✔️ Deploy Preview for wizardly-kowalevski-4abe4b ready!

🔨 Explore the source changes: 49b7828

🔍 Inspect the deploy log: https://app.netlify.com/sites/wizardly-kowalevski-4abe4b/deploys/61b229578bcc6300072bd911

😎 Browse the preview: https://deploy-preview-121--wizardly-kowalevski-4abe4b.netlify.app

@Flaque
Copy link
Contributor Author

Flaque commented Dec 8, 2021

I love the GUI @saml33! The % is a nice touch.

Screen Shot 2021-12-08 at 2 46 52 PM

@Flaque Flaque marked this pull request as ready for review December 9, 2021 16:00
@mschneider
Copy link
Contributor

@SebastianBor happy to merge this if it works out of the box. but not sure if would we need to upgrade the mango governance program, for this to work?

@SebastianBor
Copy link
Collaborator

@SebastianBor happy to merge this if it works out of the box. but not sure if would we need to upgrade the mango governance program, for this to work?

No, it won't work, we need v2 for this

@asktree asktree mentioned this pull request Mar 9, 2023
@asktree
Copy link
Contributor

asktree commented Mar 9, 2023

I am probably going to close this due to age and lack of context.

@asktree
Copy link
Contributor

asktree commented Mar 9, 2023

@mschneider @SebastianBor is this still relevant in 2023?

@SebastianBor
Copy link
Collaborator

@mschneider @SebastianBor is this still relevant in 2023?

It's an old PR but it's still relevant in terms of functionality. spl-gov didn't support custom deposit amount at that time and this is why it was put on hold.
However I think we can close this one because I wouldn't put the prompt by default when depositing tokens. That could be done as advance option from the 'My governance power' details view instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants