-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom deposit amounts #121
Add custom deposit amounts #121
Conversation
Co-authored-by: saml33 <[email protected]> Co-authored-by: flaque <[email protected]>
✔️ Deploy Preview for sad-einstein-a108a8 ready! 🔨 Explore the source changes: 49b7828 🔍 Inspect the deploy log: https://app.netlify.com/sites/sad-einstein-a108a8/deploys/61b2295782ec68000828b1d3 😎 Browse the preview: https://deploy-preview-121--sad-einstein-a108a8.netlify.app |
✔️ Deploy Preview for wizardly-kowalevski-4abe4b ready! 🔨 Explore the source changes: 49b7828 🔍 Inspect the deploy log: https://app.netlify.com/sites/wizardly-kowalevski-4abe4b/deploys/61b229578bcc6300072bd911 😎 Browse the preview: https://deploy-preview-121--wizardly-kowalevski-4abe4b.netlify.app |
I love the GUI @saml33! The % is a nice touch. |
@SebastianBor happy to merge this if it works out of the box. but not sure if would we need to upgrade the mango governance program, for this to work? |
No, it won't work, we need v2 for this |
I am probably going to close this due to age and lack of context. |
@mschneider @SebastianBor is this still relevant in 2023? |
It's an old PR but it's still relevant in terms of functionality. spl-gov didn't support custom deposit amount at that time and this is why it was put on hold. |
Revives #38 since it seems like Max's comment (blockworks-foundation#38 (comment)) here has been resolved by @SebastianBor's commit.
Opening this as a draft while I test it a bit.
Co-authored-by: saml33 [email protected]
Co-authored-by: flaque [email protected]